Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow body widget to be built without padding #73

Merged
merged 2 commits into from
Jan 15, 2022
Merged

Allow body widget to be built without padding #73

merged 2 commits into from
Jan 15, 2022

Conversation

petoknm
Copy link
Contributor

@petoknm petoknm commented Apr 28, 2021

I wanted to use introduction_screen with an Expanded bodyWidget to make sure I am using all the available space for the bodyWidget, but the widget tree was Column -> Padding -> BodyWidget. In this case I cannot use Expanded because it would have an unbounded height. So I changed it to Column -> Container -> BodyWidget where the container has a nullable padding, meaning that if the user leaves it null (as it is by default) the container will not build an inner Padding widget and would allow me to use Expanded as a body widget.

I also renamed descriptionPadding to bodyPadding since it was only used for setting the body padding and nothing else.

@Pyozer Pyozer merged commit 2cd6290 into Pyozer:master Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants